Fix changing default encoding #1296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
postgresql::server::initdb is a classthat may have no external impact to Forge modules. postgresql::server::late_initdb is a classthat may have no external impact to Forge modules. This module is declared in 70 of 578 indexed public
|
bastelfreak
reviewed
Sep 8, 2021
Starting with 79fa355 it is not possible to set a custom encoding on systems where initdb is not needed (e.g. Debian). The autorequire introduce a circular dependency: ``` dependency cycles found: (Anchor[postgresql::server::service::begin] => Postgresql_psql[Set template1 encoding to UTF-8] => Class[Postgresql::Server::Initdb] => Postgresql_conf[listen_addresses] => Class[Postgresql::Server::Service] => Anchor[postgresql::server::service::begin]) ``` Move the relevant code from postgresql::server::initdb to postgresql::server::late_initdb and include it when applicable so that the postgresql_psql command gets run after the service has started up.
bastelfreak
approved these changes
Sep 8, 2021
david22swan
approved these changes
Sep 20, 2021
cegeka-jenkins
pushed a commit
to cegeka/puppet-postgresql
that referenced
this pull request
Feb 3, 2022
Fix changing default encoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with 79fa355 it is not
possible to set a custom encoding on systems where initdb is not needed
(e.g. Debian). The autorequire introduce a circular dependency:
Move the relevant code from postgresql::server::initdb to
postgresql::server::late_initdb and include it when applicable so that
the postgresql_psql command gets run after the service has started up.